fix: quote /select path in launch(locate=True) on Windows for paths with spaces#3346
Closed
terminalchai wants to merge 1 commit into
Closed
fix: quote /select path in launch(locate=True) on Windows for paths with spaces#3346terminalchai wants to merge 1 commit into
terminalchai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2994
Problem
click.launch(path, locate=True)on Windows callsexplorer /select,{path}without quoting the path. Whenpathcontains spaces, Explorer splits at the space and opens the wrong folder.Fix
Wrap the
/select,argument in double quotes and escape any embedded"as"", following Explorer's documented command-line quoting rules (as suggested by @davidism in the issue).Tests
Added two Windows-only tests in
tests/test_termui.py:/select,argument wraps the path in double quotes when the path contains spaces""